Subject: Re: VIA ACE patch
To: Rui Paulo <firstname.lastname@example.org>
From: Daniel de Kok <email@example.com>
Date: 01/12/2007 18:40:33
On Fri, 12 Jan 2007, Rui Paulo wrote:
> #if defined(I686_CPU) && defined(VIA_PADLOCK)
> + * VIA "Nehemiah" MSRs
> + */
> Maybe all these defines should be left padded?
Done, looks much better indeed.
> In via_padlock_attach() there's a memory leak if (vp_sc->sc_cid < 0).
Jikes, shouldn't have missed that, thanks!
> It would be great if you could replace bzero/bcopy by memset/memcpy (maybe
> that should be in KNF).
Thanks for the feedback!