Subject: Re: Another krb5 enum patch
To: Ben Harris <email@example.com>
From: None <firstname.lastname@example.org>
Date: 01/07/2002 00:13:54
Ben Harris <email@example.com> writes:
> At present, the "usage" argument of create_checksum is defined to be a
> krb5_key_usage, which is an enum with values 1--24. However, in one of
> the three places create_checksum is called from, this argument is zero,
> and in the other two, it's the output of one of the *_USAGE macros, which
> will produce values outside the range of the enum. Similarly, the only
> use made of this argument is to pass it to do_checksum, which expects an
> unsigned int. Thus, I'd like to suggest the following patch, to make
> "usage" an unsigned int as well.
Yes, this makes sense. Thanks for the patch, I've applied it to the
Heimdal CVS tree.