Subject: Re: CVS commit: src/sys/sys
To: Mindaugas R. <rmind@NetBSD.org>
From: Christos Zoulas <christos@zoulas.com>
List: source-changes
Date: 01/25/2008 08:07:13
On Jan 24, 8:03pm, rmind@NetBSD.org ("Mindaugas R.") wrote:
-- Subject: Re: CVS commit: src/sys/sys
| yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
| > > Module Name: src
| > > Committed By: rmind
| > > Date: Mon Jan 21 00:27:24 UTC 2008
| > >
| > > Modified Files:
| > > src/sys/sys: types.h
| > >
| > > Log Message:
| > > Move the cpuid_t type-defintion out of the _NETBSD_SOURCE condition.
| > > Should fix the compilation of various applications. Discussed with
| > > <martin>.
| > >
| > >
| > > To generate a diff of this commit:
| > > cvs rdiff -r1.78 -r1.79 src/sys/sys/types.h
| > >
| > > Please note that diffs are not public domain; they are subject to the
| > > copyright notices on the relevant files.
| >
| > doesn't it contradict the purpose of _NETBSD_SOURCE?
|
| christos@astron.com (Christos Zoulas) wrote:
| > Yes, and this makes visible cpuid_t which is not an any standard that
| > I know off. Anyway, I had committed the fix in pthread.h, not to include
| > it unless _NETBSD_SOURCE was defined.
|
| If I understand this paper correctly, this is not true (see end of the table):
| http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_02.html#tag_02_02_02
|
| The problematic case is that sys/pset.h is included in pthread.h, because
| defintion of cpuset_t is needed. How about moving this to sys/sched.h?
I fixed that by:
#include <sys/featuretest.h>
#ifdef _NETBSD_SOURCE
#include <sys/pset.h>
#endif
I don't understand why your change was needed.
christos