Subject: Re: CVS commit: src/common/lib/libprop
To: Matt Thomas <matt@3am-software.com>
From: Andrew Doran <ad@netbsd.org>
List: source-changes
Date: 01/05/2008 01:37:29
On Fri, Jan 04, 2008 at 05:23:22PM -0800, Matt Thomas wrote:
> On Jan 4, 2008, at 5:15 PM, Andrew Doran wrote:
>
> >
> >Module Name: src
> >Committed By: ad
> >Date: Sat Jan 5 01:15:03 UTC 2008
> >
> >Modified Files:
> > src/common/lib/libprop: prop_bool.c prop_dictionary.c prop_number.c
> > prop_object.c prop_object_impl.h
> >
> >Log Message:
> >Include sys/simplelock.h in prop_object_impl.h.
>
> That's wrong. libprop is supposed to be non-NetBSD specific. And
> also usable
> in _STANDALONE environments.
>
> proplib should have no knowledge of simple locks.
Either you didn't bother to look at the change, or you're complaining to
the wrong person.
Andrew