Subject: Re: CVS commit: src/lib/libpthread
To: None <ad@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 12/25/2007 00:50:19
> - Always create LWPs detached. Do join/exit sync mostly in userland. When
>   looped on a dual core box this seems ~30% quicker than using lwp_wait().
>   Reduce number of lock acquire/release ops during thread exit.

- you don't need to check EINTR from pthread_cond_wait.
- pthread_cond_wait doesn't release the mutex on errors.
- what's pt_droplock for?  pthread_cond_wait doesn't use pthread__cancelled.
  why don't you use pthread_cleanup_push?
- what's pthread_mutex_held_np in pthread__cancelled for?

YAMAMOTO Takashi