Subject: Re: CVS commit: src/sys/dev/pci
To: Tim Rightnour <root@garbled.net>
From: Frank Wille <frank@hasenbraten.de>
List: source-changes
Date: 12/17/2007 11:40:31
Tim Rightnour wrote:
> On 17-Dec-2007 Takahiro Kambe wrote:
> 
>>This change break XEN kernel...
>>
>>/usr/src/sys/dev/pci/viaide.c: In function 'vt8231_mapregs_native':
>>/usr/src/sys/dev/pci/viaide.c:628: error: incompatible types in assignment
> 
> 
> Sorry I didn't catch this when I reviewed the change.  I wasn't aware xen used
> a struct for pci_intr_handle_t.  My bad.
> 
> I think the correct fix for this is to do something similar to what
> pciide_map_compat_intr() does, and call pciide_machdep_compat_intr_establish
> inside an ifdef __HAVE_PCIIDE_MACHDEP_COMPAT_INTR_ESTABLISH.

Yes, sorry, I should have known... :|
I will provide a fix today!

-- 
Frank Wille