Subject: CVS commit: src/share/examples/refuse/iscsi-initiator
To: None <source-changes@NetBSD.org>
From: Alistair G. Crooks <agc@netbsd.org>
List: source-changes
Date: 11/18/2007 23:52:14
Module Name:	src
Committed By:	agc
Date:		Sun Nov 18 23:52:14 UTC 2007

Modified Files:
	src/share/examples/refuse/iscsi-initiator: iscsifs.c

Log Message:
The iSCSI target returns the 0-based Max LBA in the READ_CAPACITY command,
and we need to add 1 to it to get the size of the LUN.

Revert Max LBA calculation when returning the Maximum LBA from the target
to the iinitiator, following an email conversation with Jonathan Kollasch,
who points out a number of things:

+ the NetBSD scsipi driver reads the value returned by the drive and adds
one to it, so that standard SCSI drives return the 0-based Max LBA in a
READ CAPACITY command.

+ it is up to the initiator to add 1 to the Max LBA to find out the size
of the LUN (Jonathan verified this by using the UNH iSCSI initiator on
to a NetBSD target)

+ an analogous change to the NetBSD target (revision 1.34 of
disk.c) is needed.


To generate a diff of this commit:
cvs rdiff -r1.3 -r1.4 src/share/examples/refuse/iscsi-initiator/iscsifs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.