On Sun, Oct 21, 2007 at 03:42:10PM +0200, Joerg Sonnenberger wrote:
> On Fri, Oct 19, 2007 at 09:34:56PM +0000, Pavel Cahyna wrote:
> > Log Message:
> > The control registers (notably CR3 and CR4) are 64-bit on amd64 (see
> > "AMD64 Architecture Programmer's Manual"). Declare the variables
> > holding them as vaddr_t, otherwise the upper bits are lost.
> 
> You mean paddr_t, don't you? :-) At least CR3 is a physical address after
> all.

I mean basically "anything that is 32 bit on i386 and 64 bit on amd64".

CR3 encodes a physical address, but using paddr_t could cause problems
if we add PAE support, because then I guess paddr_t will have to be 64-bit
while CR3 is still 32 bit.

I think it should stay as it is.

Pavel