Subject: Re: CVS commit: src/sys/fs/efs
To: Stephen M. Rumble <rumble@netbsd.org>
From: David Laight <david@l8s.co.uk>
List: source-changes
Date: 09/15/2007 23:07:27
On Sat, Sep 08, 2007 at 06:18:00PM +0000, Stephen M. Rumble wrote:
> 
> Module Name:	src
> Committed By:	rumble
> Date:		Sat Sep  8 18:18:00 UTC 2007
> 
> Modified Files:
> 	src/sys/fs/efs: efs_vnops.c
> 
> Log Message:
> In efs_readdir don't foolishly allocate and free dirents for each entry
> before copying them out, rather just use a single one. Further, follow
> the example of tmpfs and others by simply allocating on the stack.

How big is the 'dirent' structure ?
Allocating a non-trivial structures on the kernel stack will lead to
stack overflow problems.

	David

-- 
David Laight: david@l8s.co.uk