Subject: Re: CVS commit: [jmcneill-pm] src/sys/dev/pci
To: None <source-changes@NetBSD.org>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: source-changes
Date: 09/05/2007 01:30:25
On Tue, Sep 04, 2007 at 05:56:52PM -0400, Jared D. McNeill wrote:
> On Tue, 4 Sep 2007, DEGROOTE Arnaud wrote:
>> Modified Files:
>> 	src/sys/dev/pci [jmcneill-pm]: if_wpi.c if_wpivar.h
>>
>> Log Message:
>> Convert wpi_power to use pci_net_generic_power.
>> With this, I can use the card after resume.
>
> You should actually nuke the wpi_power function altogether and register 
> pci_net_generic_power directly via pnp_register (in wpi_attach), ie:
>
>   /* set power handler */
>   if (pnp_register(self, pci_net_generic_power) != PNP_STATUS_SUCCESS)
>           aprint_error("%s: couldn't establish power handler\n",
>               device_xname(self));

I would like to see that happen at some point in the future, but for
that I need generic storage in a struct device and we are a long way
from being able to do that properly.

Joerg