Subject: sl811hs.c compile problem (was: CVS commit: src)
To: KIYOHARA Takashi <kiyohara@NetBSD.org>
From: Bernd Ernesti <netbsd@lists.veego.de>
List: source-changes
Date: 08/23/2007 22:54:12
On Wed, Aug 15, 2007 at 03:53:10AM +0000, KIYOHARA Takashi wrote:
> 
> Module Name:	src
> Committed By:	kiyohara
> Date:		Wed Aug 15 03:53:10 UTC 2007
> 
> Modified Files:
> 	src/doc: CHANGES
> 	src/share/man/man3: Makefile
> 	src/share/man/man4: slhci.4
> 	src/sys/arch/x68k/dev: slhci_intio.c
> 	src/sys/conf: files
> 	src/sys/dev/ic: sl811hs.c sl811hsreg.h sl811hsvar.h
> 	src/sys/dev/isa: slhci_isa.c
> 	src/sys/dev/pcmcia: files.pcmcia
> Added Files:
> 	src/share/man/man3: gcq.3
> 	src/sys/sys: gcq.h
> 
> Log Message:
> Replace to Matthew Orgass's slhci(4).
> http://mail-index.netbsd.org/tech-kern/2007/06/26/0001.html

Hmmm,

/src/sys/dev/ic/sl811hs.c: In function 'slhci_do_attach':
/src/sys/dev/ic/sl811hs.c:2673: error: 'slhci_usbdebug' undeclared (first use in this function)
/src/sys/dev/ic/sl811hs.c:2673: error: (Each undeclared identifier is reported only once
/src/sys/dev/ic/sl811hs.c:2673: error: for each function it appears in.)
/src/sys/dev/ic/sl811hs.c:2674: error: 'usbdebug' undeclared (first use in this function)
*** Error code 1

First it looked ok, but taking a closer look I found that slhci_usbdebug at the top
of the source code is also inside a '#ifdef SLHCI_DEBUG'.
So I would move the #endif in line 2671 a little further down (4 lines).
This made the code compille.

Bernd