Subject: Missing or wrong CLEANDIR entry for librt (was: CVS commit: src)
To: Mindaugas Rasiukevicius <rmind@NetBSD.org>
From: Bernd Ernesti <netbsd@lists.veego.de>
List: source-changes
Date: 05/28/2007 19:07:44
Hi,

there are some files left in src/lib/librt if I do a make cleandir.

Easily noticed if you use obj dirs and then look for remaining files:

-rw-r--r--   1 cvs  cvs    38 May 28 18:25 aio_cancel.S
-rw-r--r--   1 cvs  cvs    37 May 28 18:25 aio_error.S
-rw-r--r--   1 cvs  cvs    37 May 28 18:25 aio_fsync.S
-rw-r--r--   1 cvs  cvs    36 May 28 18:25 aio_read.S
-rw-r--r--   1 cvs  cvs    38 May 28 18:25 aio_return.S
-rw-r--r--   1 cvs  cvs    39 May 28 18:25 aio_suspend.S
-rw-r--r--   1 cvs  cvs    37 May 28 18:25 aio_write.S
-rw-r--r--   1 cvs  cvs    38 May 28 18:25 lio_listio.S

Hmm,

CLEANFILES+=    ${PSEUDO}

looks a little strange in src/lib/librt/sys/Makefile.inc
I don't see where PSEUDO would be defined in this Makefile, maybe
you meant to use ASM here.

Bernd

On Mon, Apr 30, 2007 at 02:44:31PM +0000, Mindaugas Rasiukevicius wrote:
> 
> Module Name:	src
> Committed By:	rmind
> Date:		Mon Apr 30 14:44:31 UTC 2007
> 
> Modified Files:
> 	src/distrib/sets/lists/comp: mi
> 	src/include: Makefile
> 	src/lib/librt: Makefile
> 	src/sys/conf: files
> 	src/sys/ddb: db_command.c db_interface.h db_xxx.c
> 	src/sys/kern: kern_exit.c kern_fork.c syscalls.master
> 	src/sys/sys: Makefile proc.h unistd.h
> Added Files:
> 	src/include: aio.h
> 	src/lib/librt/sys: Makefile.inc
> 	src/sys/kern: vfs_aio.c
> 	src/sys/sys: aio.h
> 
> Log Message:
> Import of POSIX Asynchronous I/O.
> Seems to be quite stable. Some work still left to do.
> 
> Please note, that syscalls are not yet MP-safe, because
> of the file and vnode subsystems.
> 
> Reviewed by: <tech-kern>, <ad>
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.1020 -r1.1021 src/distrib/sets/lists/comp/mi
> cvs rdiff -r1.126 -r1.127 src/include/Makefile
> cvs rdiff -r0 -r1.1 src/include/aio.h
> cvs rdiff -r1.1 -r1.2 src/lib/librt/Makefile
> cvs rdiff -r0 -r1.1 src/lib/librt/sys/Makefile.inc
> cvs rdiff -r1.837 -r1.838 src/sys/conf/files
> cvs rdiff -r1.95 -r1.96 src/sys/ddb/db_command.c
> cvs rdiff -r1.19 -r1.20 src/sys/ddb/db_interface.h
> cvs rdiff -r1.42 -r1.43 src/sys/ddb/db_xxx.c
> cvs rdiff -r1.173 -r1.174 src/sys/kern/kern_exit.c
> cvs rdiff -r1.137 -r1.138 src/sys/kern/kern_fork.c
> cvs rdiff -r1.168 -r1.169 src/sys/kern/syscalls.master
> cvs rdiff -r0 -r1.1 src/sys/kern/vfs_aio.c
> cvs rdiff -r1.93 -r1.94 src/sys/sys/Makefile
> cvs rdiff -r0 -r1.1 src/sys/sys/aio.h
> cvs rdiff -r1.244 -r1.245 src/sys/sys/proc.h
> cvs rdiff -r1.35 -r1.36 src/sys/sys/unistd.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>