Subject: Re: CVS commit: src/sbin/shutdown
To: Christos Zoulas <christos@netbsd.org>
From: Bill Stouder-Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 03/14/2007 10:51:37
--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 14, 2007 at 03:52:28AM +0000, Christos Zoulas wrote:
>=20
> Module Name:	src
> Committed By:	christos
> Date:		Wed Mar 14 03:52:28 UTC 2007
>=20
> Modified Files:
> 	src/sbin/shutdown: Makefile shutdown.c
>=20
> Log Message:
> - sprinkle static
> - pass WARNS=3D4 and lint
> - use size_t/time_t where appropriate
> - get/setprogname()
> - before executing rc.shutdown, set the real user id to 0, because shutdo=
wn
>   scripts may depend on it (for example su depends on being root).
> - use warn instead of perror, and make sure we use the right errno.

Could at least the real user id part be pulled into the 4.X branch? All of=
=20
it would be fine too.

Take care,

Bill

--7AUc2qLy4jB3hD7Z
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (NetBSD)

iD8DBQFF+EQ5Wz+3JHUci9cRAvKlAJ4tBkn0/hlpv/ixLUAaHNOblyJBxQCfY3GQ
pkcMjgFPODSRMv3p2m16FO8=
=PUDQ
-----END PGP SIGNATURE-----

--7AUc2qLy4jB3hD7Z--