Subject: Re: CVS commit: src/sys/dev/pci
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Michael Lorenz <macallan@netbsd.org>
List: source-changes
Date: 02/10/2007 01:06:50
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello,
On Feb 9, 2007, at 20:22, Izumi Tsutsui wrote:
> macallan@NetBSD.org wrote:
>
>> Module Name: src
>> Committed By: macallan
>> Date: Fri Feb 9 21:39:38 UTC 2007
>>
>> Modified Files:
>> src/sys/dev/pci: if_tlp_pci.c
>>
>> Log Message:
>> add a quirks entry for the DEC21140 found on UMAX E100 cards
>
> The following changes are intended?
Oops, looks like ancient debugging leftovers
> (addr and size should be bus_addr_t and bus_size_t anyway)
I'll get rid of that, thanks for noticing :)
> @@ -360,7 +363,7 @@
> prop_data_t ea;
> u_int8_t enaddr[ETHER_ADDR_LEN];
> u_int32_t val = 0;
> - pcireg_t reg;
> + pcireg_t reg, addr, size;
> int error;
>
> sc->sc_devno = pa->pa_device;
> @@ -533,13 +536,13 @@
> /*
> * Map the device.
> */
> +
> ioh_valid = (pci_mapreg_map(pa, TULIP_PCI_IOBA,
> PCI_MAPREG_TYPE_IO, 0,
> &iot, &ioh, NULL, NULL) == 0);
> memh_valid = (pci_mapreg_map(pa, TULIP_PCI_MMBA,
> PCI_MAPREG_TYPE_MEM|PCI_MAPREG_MEM_TYPE_32BIT, 0,
> - &memt, &memh, NULL, NULL) == 0);
> -
> + &memt, &memh, &addr, &size) == 0);
> if (memh_valid) {
> sc->sc_st = memt;
> sc->sc_sh = memh;
have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iQEVAwUBRc1g+spnzkX8Yg2nAQLdwAf/aafrejB1iBNaAee0AIz8zZ0gS2aPbKxV
+4tdXjjHD+d1XPSpfcQ6X2dMT7Al+/HFiIV1KdfHSTn9unUmcPVvQSfI/fdHFVMA
0S0vhVT8CmjR3XMRH+H7JlKo38ErgM/SiLWdDu6wpY2j8S9GjXNyjJhHsPHZ7FdP
IJDU3SOFnyTheUAWOfcx9A06wdCl3p+nIi7rIxfva2GFDRuoUzfkUMUybOKNaxxr
7a6yFveEfTmnfk//ByqpDD1pgC/eBTX4M4lI4S0CTY3CneiGFSlsQT0kX0IU5Lgo
OQBFKZP8s6lfHjlqYFOXZFM/KEymco1q849VADdxqJqD40wgrNEa2w==
=rkO1
-----END PGP SIGNATURE-----