source-changes: Re: CVS commit: src/sys/dev/pci

Subject: Re: CVS commit: src/sys/dev/pci
To: Arnaud Lacombe <alc@netbsd.org>
From: Pavel Cahyna <pavel@netbsd.org>
List: source-changes
Date: 12/26/2006 02:00:02

On Mon, Dec 25, 2006 at 11:58:36PM +0000, Arnaud Lacombe wrote:
> 
> Module Name:	src
> Committed By:	alc
> Date:		Mon Dec 25 23:58:36 UTC 2006
> 
> Modified Files:
> 	src/sys/dev/pci: if_nfe.c
> 
> Log Message:
> CID-3667: check if 'mtag != NULL' before dereferencing it

How does it fix the bug? Before, if mtag was NULL -> crash. Now, if mtag
is NULL -> crash. Where is the difference?

Is the purpose of this change to silence Coverity? If it does, it actively
causes harm, because it *hides* the bug.

Pavel