On Dec 1, 2006, at 11:42 AM, Christian Biere wrote:

> Manuel Bouyer wrote:
>> On Fri, Dec 01, 2006 at 08:36:23PM +0100, Christian Biere wrote:
>>> Manuel Bouyer wrote:
>>>>>> Add __aligned__(4) to all the structures.
>>>>>
>>>>> Uh oh... I wonder if maybe putting it on all the structures  
>>>>> wasn't such
>>>>> a good idea after all... while the ATA/ATAPI devices seem OK,  
>>>>> SCSI seems
>>>>> broken now:
>>>
>>>> I've not looked closely at the commit but I suspect some structs  
>>>> here are
>>>> really used unaligned, packed with some other, or a single int8.
>>>
>>> I suggest using STATIC_ASSERT(sizeof(struct whatever) == whatever)  
>>> wherever
>>> size matters.
>>
>> It matters on all of these structures.
>
> Does __aligned__ add trailing padding?

Leading or trailing, depending on where an individual one is placed.

-- thorpej