Subject: Re: CVS commit: src/sys/arch/i386/conf
To: Izumi Tsutsui <email@example.com>
From: Perry E. Metzger <firstname.lastname@example.org>
Date: 11/27/2006 14:41:10
Izumi Tsutsui <email@example.com> writes:
>> Hmm, was there (I don't think I followed the discussion)? We have
>> quite a number of configs (about 40) for arm, ppc, and mips ports that
>> use CPUFLAGS precisely for supplying appropriate -mfoo options as the
>> port (or the specific machine that the config targets) is known to
>> have given cpu variant.
> Well, if it's the conclusion, please commit proper fixes as core.
> Our commit guidelines say "don't revert other developer's commits."
I think that it is okay to revert someone's commits if they are
unresponsive. We don't have to wait indefinitely for their assent if
they don't respond at all. If they are available and say "no" it is
different from them being out of touch and saying nothing.
If it was me who had committed something that broke part of the build,
and I went on vacation or otherwise became impossible to reach, I
would want people to fix what I broke even though they can't reach me.