Subject: Re: CVS commit: src/sys/arch/i386/conf
To: Izumi Tsutsui <firstname.lastname@example.org>
From: Valeriy E. Ushakov <email@example.com>
Date: 11/27/2006 19:42:56
On Tue, Nov 28, 2006 at 01:14:53 +0900, Izumi Tsutsui wrote:
> > I don't see the problem. Your change hides the problem, and
> > prevents us from understanding what is going on, so I would back
> > it out.
> If anyone handled it, there was no problem for me.
> (I'm not in a position to resolve i386 specific issue anyway)
tls@ added -mfoo to COPTS (e.g. 1.794 of GENERIC). The fix is to add
-mfoo to CPUFLAGS instead (we have plenty of configs that do that),
not adding -O2 to COPTS in the config.
The real issue of course is that kernel makefile uses COPTS
incorrectly. bsd.README documents COPTS as "ADDITIONAL flags to the
compiler when creating C objects" (emphasis mine), so we can't really
blame Thor except for trusting the docs :).
firstname.lastname@example.org | Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/ | Ist zu Grunde gehen