Subject: Re: CVS commit: src/usr.sbin/installboot
To: None <source-changes@NetBSD.org>
From: Christian Biere <christianbiere@gmx.de>
List: source-changes
Date: 11/01/2006 01:21:55
Tom Spindler wrote:
> Are braces really such a horrible solution for this?
> 
> gcc doesn't complain in the least about
> 
> 	if (params->fstype->needswap) {
> 		/* function that #defines to empty space */
> 	}

If it's a function I'd consider using a (static inline) function instead
of a macro as far as possible, that's also better for type-safety if
the non-empty variant is seldomly used.

> Then again, I dislike with the "No braces are used for control
> statements with zero or only a single argument[...]" in share/misc/style.

Bikeshead ahead. *must resist* Me too. *arrg*

-- 
Christian