Subject: Re: CVS commit: src
To: matthew green <mrg@eterna.com.au>
From: Elad Efrat <elad@NetBSD.org>
List: source-changes
Date: 09/09/2006 09:59:53
This is a multi-part message in MIME format.

--Boundary_(ID_Adyp6A9Up1iNzOz4hLZFmw)
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 7BIT

matthew green wrote:

> something is broken here i think.  my sparc64 system can't run ntpd.
> it spins calling geteuid() and ntp_ajdtime().  ntp_adjtime() gets an
> EPERM ...  it doesn't matter if i run ntpd as root or as ntpd:ntpd.

Can you try attached patch?

-e.

-- 
Elad Efrat

--Boundary_(ID_Adyp6A9Up1iNzOz4hLZFmw)
Content-type: text/plain; name=ntp_adjtime.diff
Content-transfer-encoding: 7BIT
Content-disposition: inline; filename=ntp_adjtime.diff

Index: kern_ntptime.c
===================================================================
RCS file: /usr/cvs/src/sys/kern/kern_ntptime.c,v
retrieving revision 1.36
diff -u -p -r1.36 kern_ntptime.c
--- kern_ntptime.c	8 Sep 2006 20:58:57 -0000	1.36
+++ kern_ntptime.c	8 Sep 2006 06:39:48 -0000
@@ -1017,8 +1017,8 @@ sys_ntp_adjtime(l, v, retval)
 	if (error != 0)
 		return (error);
 
-	if (ntv.modes != 0 && (error = kauth_authorize_network(l->l_cred,
-	    KAUTH_SYSTEM_TIME, (void *)KAUTH_REQ_SYSTEM_TIME_NTPADJTIME, NULL,
+	if (ntv.modes != 0 && (error = kauth_authorize_system(l->l_cred,
+	    KAUTH_SYSTEM_TIME, KAUTH_REQ_SYSTEM_TIME_NTPADJTIME, NULL,
 	    NULL, NULL)) != 0)
 		return (error);
 

--Boundary_(ID_Adyp6A9Up1iNzOz4hLZFmw)--