On Sep 4, 12:46am, tsutsui@ceres.dti.ne.jp (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src/sys/dev/ic

| christos@NetBSD.org wrote:
| 
| > Module Name:	src
| > Committed By:	christos
| > Date:		Sat Sep  2 07:00:23 UTC 2006
| > 
| > Modified Files:
| > 	src/sys/dev/ic: mb89352.c
| > 
| > Log Message:
| > comment out impossible code
| 
| Isn't it better to make sc_dleft signed?
| (maybe this code should be wrapped by #ifdef DIAGNOSTIC anyway)

I think that keeping things unsigned makes the code simpler. Having
the checks always in the kernel prevents buffer overflows and crashes.

christos