Subject: Re: CVS commit: src
To: Iain Hibbert <plunky@netbsd.org>
From: Quentin Garnier <cube@cubidou.net>
List: source-changes
Date: 08/20/2006 10:45:16
--vc+O+Moll5ceXJgw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 20, 2006 at 07:06:58AM +0000, Iain Hibbert wrote:
>=20
> Module Name:	src
> Committed By:	plunky
> Date:		Sun Aug 20 07:06:58 UTC 2006
>=20
> Modified Files:
> 	src/share/man/man4: btdev.4
> 	src/sys/arch/i386/conf: GENERIC GENERIC_LAPTOP
> 	src/sys/dev/bluetooth: btdev.c
>=20
> Log Message:
> Make btdev default count explicit

Hard-coded limits are ugly.  Why don't you simply do the
config_attach_pseudo in btdevopen?

That way, you don't need sc_busy anymore;  the mere fact that there is
a softc indicates that it's being used, and then you config_detach in
btdevclose.  The next step is to have a cloning char device, so that
you only have one device node so you don't have to create btdev0,
btdev1, etc.  You'd only have /dev/btdev and userland wouldn't have to
know before hand which unit is used.

I don't have any bluetooth stuff, so I can't test but the code is rather
easy.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--vc+O+Moll5ceXJgw
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (NetBSD)

iQEVAwUBROghHNgoQloHrPnoAQI9gwgAsh7a+HhYBqLAV2zjgYzKRTHTptxJJGvd
2WmwLBdhoMgsBxuGs/K7IQPDGjgAtdY8m0Otm2FGgq2VL/4zo7zuyjey1yKP+Fi4
HF6+touz1ARRlJH/0/qHRibtzSDhNB2+0+njshgMIb5FRlVaqg46w0s7HtwzfViF
tdAF+mnKU7D9Q42UXnSIMxQTwuk6SN8Gb02PTNKibiTXa4rcwnuPPh/iSPCYKypb
3MAF3NwTFv8cXkDE1M4E+/RJQWTJoxnUcHUt2vVUnzcAZEPVdRD3adx8KIoxsUkL
vf6jb/Y6gGJknC8XLzlJVprxA6GLKiwzmaUCu4i5ROr6rkGh8kdOFA==
=Sx0v
-----END PGP SIGNATURE-----

--vc+O+Moll5ceXJgw--