Subject: Re: CVS commit: src
To: None <>
From: Perry E. Metzger <>
List: source-changes
Date: 08/06/2006 19:33:04
Daniel Carosone <> writes:
> On Sun, Aug 06, 2006 at 08:53:12PM +0200, Quentin Garnier wrote:
>> > >  - you don't free freq_names if k8pnow_current_state is NULL (what if
>> > >    the PSB doesn't list the current state?  you know vendors...  I
>> > >    certainly expect one to ship a laptop with a broken PSB but a correct
>> > >    ACPI table)
>> > 
>> > Fixed.
>> No.  As I said, Coverity will tell you.
> Just a side comment..  regardless of the rest of the details, it is
> unfair to criticise Juan for not getting code review, while at the
> same time providing feedback that is, I have to say, cryptic at best.

I don't think this is terribly cryptic, especially since he posted
other messages explaining the problem and was in private touch with