Subject: Re: CVS commit: src/sys/kern
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Andrew Doran <ad@NetBSD.org>
List: source-changes
Date: 07/19/2006 11:19:57
Hi Yamamoto-san,

On Wed, Jul 19, 2006 at 08:53:43AM +0900, YAMAMOTO Takashi wrote:

> > - Always make p->p_cred a private copy before modifying.
> > - Share credentials among processes when forking.
> 
> do you have a plan to add some locking?
> "p->p_cred = kauth_cred_copy(p->p_cred);" is not safe
> as kauth_cred_copy can sleep.

The change to per-LWP creds will solve this problem for the most part. I
hope to make those changes in the next day or two.

Thanks,
Andrew