Subject: CVS commit: [chap-midi] src/sys/dev
To: None <source-changes@NetBSD.org>
From: Chapman Flack <chap@netbsd.org>
List: source-changes
Date: 06/07/2006 01:23:10
Module Name:	src
Committed By:	chap
Date:		Wed Jun  7 01:23:10 UTC 2006

Modified Files:
	src/sys/dev [chap-midi]: midisynvar.h
	src/sys/dev/ic [chap-midi]: opl.c
	src/sys/dev/isa [chap-midi]: cms.c midi_pcppi.c

Log Message:
The midisyn clients now use designated initializers so the method
structure can evolve. Only opl currently provides any methods beyond
open/close/note-on/note-off. Only cms takes a note number; the others
want a frequency. This is good because it is much easier that way to
put a common handler for tuning/pitchbend/portamento in midisyn itself.

Next up, axe most methods nobody implements. Split note-on into two
methods, one with a frequency, one with a note number, of which a driver
provides one or the other. So far all of the clients delegate voice
allocation to midisyn, so clarify that the method is getting an actual
voice number for the device and not a MIDI channel. If a device that can
do its own allocation is later to be supported, let appropriate different
methods be added then.


To generate a diff of this commit:
cvs rdiff -r1.9.14.11 -r1.9.14.12 src/sys/dev/midisynvar.h
cvs rdiff -r1.24 -r1.24.2.1 src/sys/dev/ic/opl.c
cvs rdiff -r1.11 -r1.11.14.1 src/sys/dev/isa/cms.c
cvs rdiff -r1.12 -r1.12.14.1 src/sys/dev/isa/midi_pcppi.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.