Subject: Re: CVS commit: src/sys/conf
To: None <source-changes@NetBSD.org>
From: Luke Mewburn <lukem@NetBSD.org>
List: source-changes
Date: 04/21/2006 16:19:58
--FcSpk3Icpd/Pbul4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 20, 2006 at 12:09:02PM -0400, Perry E. Metzger wrote:
  | Luke Mewburn <lukem@netbsd.org> writes:
  | > Module Name:	src
  | > Committed By:	lukem
  | > Date:		Wed Apr 19 07:08:17 UTC 2006
  | >
  | > Modified Files:
  | > 	src/sys/conf: Makefile.kern.inc
  | >
  | > Log Message:
  | > Order & uniq DEPS, a la <bsd.dep.mk>.
  |=20
  | I like this in principle, but it results in lots of successive
  | directory lookups in different directories because it sorts only
  | across the last component. This can thrash the icache on older
  | boxes. Maybe we could rig it to sort by full path name so the
  | successive lookup are grouped by directory? Just reordering the :
  | operators should do that I think...

"Show me the numbers".

I did some experiments on one of my systems (a 3-year-old 2.4GHz P4)
and there was effectively no difference in a clean "make depend"
of a kernel between:
    *	the original unordered list of DEPS
    *	my change to order DEPS by final component
    *	your proposal to order DEPS by the entire source file pathname

(This was not surprising to me, given the large number of header
files across diverse directories that the mkdep(1) of any given
source file reads.)

I prefer the asthetics of the ordering of the entries that my change
provides, and the consistency with the rest of our build system.

--FcSpk3Icpd/Pbul4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (NetBSD)

iD8DBQFESHmOpBhtmn8zJHIRAmwmAJ4n7MC/yPNuSLbP7D3FlxnVX/59oQCfUeG0
CNmqE/sUG6L9vqs9JKY22q4=
=PROP
-----END PGP SIGNATURE-----

--FcSpk3Icpd/Pbul4--