Subject: Re: CVS commit: src/sys/uvm
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Christos Zoulas <christos@zoulas.com>
List: source-changes
Date: 04/13/2006 09:09:41
On Apr 13,  5:29pm, yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/uvm

| > Module Name:	src
| > Committed By:	christos
| > Date:		Thu Apr 13 01:11:08 UTC 2006
| > 
| > Modified Files:
| > 	src/sys/uvm: uvm_map.c
| > 
| > Log Message:
| > Coverity CID 762: Protect against NULL dereferencing entry->object.uvm_obj
| > like we do a few lines before. Maybe all the tests should be changed
| > to UVM_ET_ISOBJ(), or the macro should do it internally?
| > 
| > 
| > To generate a diff of this commit:
| > cvs rdiff -r1.216 -r1.217 src/sys/uvm/uvm_map.c
| 
| - i don't think it can be NULL.
| - why be different from uvm_map_clip_end?

- So why check for it being NULL a few lines above?
- It should be the same.

christos