christos@astron.com (Christos Zoulas) writes:
> In article <20060411172629.GF29748@snowdrop.l8s.co.uk>,
> David Laight  <david@l8s.co.uk> wrote:
>>On Mon, Apr 10, 2006 at 10:01:06PM +0000, Manuel Bouyer wrote:
>>> 
>>> Module Name:	src
>>> Committed By:	bouyer
>>> Date:		Mon Apr 10 22:01:06 UTC 2006
>>> 
>>> Modified Files:
>>> 	src/sys/ufs/ffs: ffs_snapshot.c
>>> 
>>> Log Message:
>>> Revert previous; I mixed bpp and *bpp when reading ffs_balloc_ufs1().
>>> ffs_balloc() will always allocate a new buffer or leave it as NULL,
>>> so coverity is wrong here, we're not using a freed argument.
>>
>>Yes - it took me a dozen reads of that code to realise it was ok.
>>Including looking at the pre-UBC version.
>>I suspect the logic is too complicated :-)
>
> Can't we simplify it a bit? It is a brain teaser...

Indeed. Code has to be read by people as well as machines...

Perry