Subject: Re: CVS commit: src/usr.sbin/pkg_install/lib
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Hubert Feyrer <hubert@feyrer.de>
List: source-changes
Date: 03/17/2006 18:45:45 
On Sat, 18 Mar 2006, YAMAMOTO Takashi wrote:
>> 	src/usr.sbin/pkg_install/lib: str.c
>>
>> Log Message:
>> findbestmatchingname_fn(): only do something sensible if the pointer
>> handed in is actually usable (not NULL)
>>
>> Fixes Coverity ID 870
>
> have you tested?
>
> i think this makes dewey_cmp crash by passing best_version = NULL,
> when best = "".

Indeed, you're right. I've actually tested it now (didn't do so before 
:-/), and it works now.

Sorry for the mess!


  - Hubert