Subject: Re: CVS commit: src/sys/dev/pci
To: Jason Thorpe <>
From: Quentin Garnier <>
List: source-changes
Date: 02/23/2006 19:42:10
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 23, 2006 at 10:38:13AM -0800, Jason Thorpe wrote:
> On Feb 21, 2006, at 6:57 PM, Tim Rightnour wrote:
> >
> >Module Name:	src
> >Committed By:	garbled
> >Date:		Wed Feb 22 02:57:26 UTC 2006
> >
> >Modified Files:
> >	src/sys/dev/pci: autri.c if_pcn.c
> >
> >Log Message:
> >IBM makes a pcn card that shows up as:
> >Trident Microsystems 4DWAVE DX (ethernet network, revision 0x25)
> >Unfortunately, this is an autri sound card.  Special case the match =20
> >routines
> >for both drivers so if_pcn properly picks it up, and autri doesn't.
> The if_pcn.c change is OK, but I don't like the autri.c change.  In =20
> autri.c, rather than checking for one (of many) classes that you =20
> don't want, instead you should check for the class that you DO want, =20
> which in this case is probably PCI_CLASS_MULTIMEDIA (but you'll want =20
> to verify that with someone who actually has the device).

Why not making pcn_match return a greater value for that board?  I don't
see why autri should change, somehow.

Quentin Garnier - -
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

Content-Type: application/pgp-signature
Content-Disposition: inline

Version: GnuPG v1.2.6 (NetBSD)