Subject: Re: CVS commit: src/sys/dev/pci
To: None <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 02/15/2006 16:15:23
On Feb 15, 2006, at 4:02 PM, Gavan Fantom wrote:
> Module Name: src
> Committed By: gavan
> Date: Thu Feb 16 00:02:00 UTC 2006
> Modified Files:
> src/sys/dev/pci: if_wm.c
> Added Files:
> src/sys/dev/pci: if_wmvar.h
> Log Message:
> Compute the EEPROM checksum to determine the presence of valid
> EEPROM data.
> If EEPROM data is invalid, allow a MD hook to supply EEPROM data
An MD hook is wrong. You should be using properties for this (you
can set the property in your platform's device_register() routine).
(Yes, I know that there are currently other drivers that do this
incorrectly, but those came before properties existed in our kernel.)
In general, changes like this should be reviewed...