Subject: Re: CVS commit: src/sys
To: David Laight <email@example.com>
From: Jeff Rizzo <riz@NetBSD.org>
Date: 02/03/2006 17:15:19
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
Content-Type: text/plain; charset=ISO-8859-1
David Laight wrote:
> On Thu, Feb 02, 2006 at 08:16:53AM -0800, Jeff Rizzo wrote:
>> I'm not certain this is the specific commit that caused it, but amd64
>> kernels which are not optimized (like, say, GENERIC) fail to link due =
>> looking for bswap16 and bswap32. I looked things over, but am not sur=
>> of the correct way to fix this...
> I'm not sure where I changed the effect of building non-optimised kerne=
> I'm fairly sure the const-folding and __inline versions were both insid=
> #if __OPTIMISE__. I don't think it makes any sense for it to be otherwi=
> libkern (or somewhere) may need to contain extern defns of bswapnn()
> anyway - for cases where the #define doesn't apply (do we allow the
> address of bswapnn() to be taken?)
> It is also worth noting that the libc functions are __bswap16(), __bswa=
> and bswap64() on i386 and amd64, whereas the kernel ones never have the=
> the leading underscores.
> I'll look at what happens to unoptimised code later.
OK, I've discovered the source of this - I had COPTS+=3D-pipe and
CFLAGS+=3D-pipe in my /etc/mk.conf . Without these, GENERIC builds at th=
default -O2 level, and consequently links. This at least explains why
nobody else saw GENERIC fail to build.
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----