Subject: Re: CVS commit: src/sys/lib/libkern/arch/hppa
To: YAMAMOTO Takashi <firstname.lastname@example.org>
From: Perry E. Metzger <email@example.com>
Date: 12/27/2005 22:00:38
YAMAMOTO Takashi <firstname.lastname@example.org> writes:
>> > Module Name: src
>> > Committed By: yamt
>> > Date: Tue Dec 27 08:49:35 UTC 2005
>> > Modified Files:
>> > src/sys/lib/libkern/arch/hppa: Makefile.inc
>> > Log Message:
>> > fix build of bzero.
>> > XXX is it better to remove it as i386?
>> Since systm.h #defines it in terms of memset, it is never actually
>> used. I would suggest removing it.
> are you sure that the prototype in libkern.h is not used?
When I removed it from the i386 port nothing happened. It is possible
that the hppa port is slightly different, but if it is, you should be
able to fix it just by including systm.h in the right place.
One big advantage of memset is that gcc inlines it. (It also has a
horrible interface compared to bzero, but...)