Subject: Re: CVS commit: src/sys
To: YAMAMOTO Takashi <>
From: Chuck Silvers <>
List: source-changes
Date: 12/27/2005 14:49:24
On Sat, Dec 24, 2005 at 03:28:06PM +0900, YAMAMOTO Takashi wrote:
> > One thing I noted in this change is that vget() will now call 
> > VOP_INACTIVE() on vnodes that were never activated. Will this cause issues 
> > with other file systems?
> what kind of issues?
> afaik, vn_lock fails only when the vnode is being reclaimed.
> in that case, calling vrele doesn't hurt.

I'm also suspicious of this change.  this change doesn't seem related
to the purpose given in the check-in comment, is it?  if you really want
to reduce the amount of duplicate code, why not just split it into
multiple functions?

also, do we really another flag that means the same thing as VXLOCK?
why not just use VXLOCK?  this would mean rearranging vgonel(), vclean(),
etc, a bit, but the result would be much nicer.