Subject: Re: CVS commit: src/sys/kern
To: Reinoud Zandijk <email@example.com>
From: James Chacon <firstname.lastname@example.org>
Date: 12/14/2005 16:34:34
On Wed, Dec 14, 2005 at 11:19:20PM +0100, Reinoud Zandijk wrote:
> On Wed, Dec 14, 2005 at 09:42:52PM +0000, David Laight wrote:
> > > > > If the rval is SCAN_CONTINUE it now returns a standard error that no
> > > > > disklabel was found instead of the NULL.
> > > >
> > > > Hummm - that was more or less deliberate, IIRC some of the callers
> > > > need a disklabel filled in with partition 'a' and 'd' when there
> > > > is nothing found on the disk.
> Deliberate??? you leave an obvious bug there deliberately?
> > I've reverted it, it breaks the default label for disks that have neither
> > MBR nor NetBSD label.
> > There may be alternative fixes to retain more of the default label...
> Sounds like those places need fixing! The `default label' IS still passed
> back only the resulting string changed.
> Without the change its impossible to tell by the caller that a disklabel is
> present or not and thus is impossible to select the default label.
Even so, this is why you bring things like this up for discussion on a
tech-X list and don't just change core code w/o some form of review. It
was there for a reason before.