Subject: Re: CVS commit: src/sys/dev/acpi
To: matthew green <firstname.lastname@example.org>
From: Quentin Garnier <email@example.com>
Date: 12/13/2005 02:07:30
Content-Type: text/plain; charset=us-ascii
On Tue, Dec 13, 2005 at 11:31:38AM +1100, matthew green wrote:
> Module Name: src
> Committed By: cube
> Date: Mon Dec 12 15:04:50 UTC 2005
> Modified Files:
> src/sys/dev/acpi: acpi.c acpivar.h
> src/sys/dev/acpi/acpica/Osd: OsdEnvironment.c
> Log Message:
> Move the (one liner) logic of AcpiOsGetRootPointer() out of acpica/Osd=
> acpi.c and take the opportunity to create a sysctl node that contains =
> address of the main ACPI table.
> The name of the node, "machdep.acpi_root", is questionable but matches=
> one FreeBSD has, which will make it easier to port their acpidump(8)
> regardless of what freebsd uses, "machdep" in MD code seems wrong.
Hence my comment about it being questionable; making it go as
hw.acpi_root or hw.acpi.root or whatever is not a hard task, and will
not really make anything else complicated.
Any suggestion about something everyone would agree on? At least that
one has a precedent :)
One thing should be noted: FreeBSD creates that node in MD code,
although in the end it is used by a MI userland program, and the data
type involved is 64-bit long whichever the arch is.
Quentin Garnier - firstname.lastname@example.org - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
-----END PGP SIGNATURE-----