Subject: Re: CVS commit: src/sys/dev/scsipi
To: None <>
From: Simon Burge <>
List: source-changes
Date: 12/09/2005 10:09:35
Manuel Bouyer wrote:

> Module Name:	src
> Committed By:	bouyer
> Date:		Thu Dec  8 22:14:19 UTC 2005
> Modified Files:
> 	src/sys/dev/scsipi: sd.c
> Log Message:
> Some USB devices reports themselves as removable, but have no door and
> so don't support the SCSI_PREVENT_ALLOW_MEDIUM_REMOVAL command.
> When an "Illegal field in CDB" is reported for this command, mark the
> device as non-removable (which is always true for USB keys from the SCSI
> point of view), print a message and ignore the error.
> For DIOCLOCK, return ENOTTY if the device is not removable instead of
> trying a command which will fail.
> Fix a problem reported by Hubert Feyrer for some USB umass devices, patch
> tested by him.

After this chamge, sd.c doesn't build any more:

sys/dev/scsipi/sd.c: In function `sd_interpret_sense':
sys/dev/scsipi/sd.c:1364: error: request for member `opcode' in something not a structure or union
sys/dev/scsipi/sd.c:1365: error: `SSD_KEY' undeclared (first use in this function)
sys/dev/scsipi/sd.c:1365: error: (Each undeclared identifier is reported only once
sys/dev/scsipi/sd.c:1365: error: for each function it appears in.)
sys/dev/scsipi/sd.c:1366: error: structure has no member named `add_sense_code'
sys/dev/scsipi/sd.c:1367: error: structure has no member named `add_sense_code_qual'

Simon Burge                            <>
NetBSD Support and Service: