Subject: Re: CVS commit:
To: Michael Lorenz <firstname.lastname@example.org>
From: Perry E. Metzger <email@example.com>
Date: 12/08/2005 23:11:30
Michael Lorenz <firstname.lastname@example.org> writes:
>> Anyway, making assumptions based on processor architecture is bogus.
> True, but...
> - are we likely to encounter a Rage 128 in a BeBox at all?
> - the other drivers do the same, basically to tell Macs from PCs
> - I think a compile time option is good enough ( and it can be recycled
> for other drivers ), should probably go into a Makefile and pass
> -DNEEDS_VGAHW or something like that based on which port we're
> running on. The problem isn't about running text mode, it's about
> being able to access the VGA registers.
At the very least, if there are going to be ifdefs, they should be
feature based rather than arch based.