Subject: Re: CVS commit: src/lib/libc/rpc
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Perry E. Metzger <perry@piermont.com>
List: source-changes
Date: 11/08/2005 10:38:24
YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> writes:
>> >> Use kqueue(2) instead of poll(2) to wait for replies and timeouts
>> >> in the UDP RPC client code. As a side-effect, this fixes some bugs
>> >> that might prevent the RPC call from ever timing out for example
>> >> if the server keeps responding with the wrong xid. This could
>> >> probably be simplified further by using the EVFILT_TIMER filter.
>> >
>> > we can keep the timeout fixes and just go back to pollts() as the
>> > mechanism for sleeping.  do you want to code that up or should I?
>> 
>> Ultimately, kqueue is a better mechanism for a number of reasons. Is
>> there no fix we can make, either to kqueue or to the program, to allow
>> us to use kqueue?
>
> what's a "number of reasons", given that
> the code in question merely polls a single descriptor?

One important one to me is that it is easier to twist the code into
operating in a a fully event driven environment if it uses kqueue. I
agree, though, that this is not crucial at the moment and I can make
do without it, since the code needs modification anyway. Still, it
would be nice.

Perry