Subject: Re: CVS commit: src/sys/dev/ic
To: Christos Zoulas <christos@zoulas.com>
From: Jason Thorpe <thorpej@shagadelic.org>
List: source-changes
Date: 10/28/2005 12:18:22
On Oct 28, 2005, at 7:33 AM, Christos Zoulas wrote:

> While this would be nice, this is not the case right now as the  
> following
> code shows taken from ether_ioctl:

I thought your commit message talked about add/del multi (see 6th  
bullet):

----------------------------
revision 1.41
date: 2005/10/28 00:01:53;  author: christos;  state: Exp;  lines:  
+81 -62
 From FreeBSD:
- make a few functions static
- introduce gem_bitwait() to factor out some of the register wait code.
- add gem_stop() in attach
- some DEBUG should be GEM_DEBUG
- handle underrun, packet too long, and overflow errors by resetting  
the chip
- add handler in ioctl for add/del multi
- fix typo
Also:
- add a shadow sc_if_flags member so that we don't reset the chip if we
   don't need to.
----------------------------

If you meant flags, then that's what you should have said in the  
commit message.

-- thorpej