Subject: Re: CVS commit: src/sys/dev/ic
To: None <>
From: Jason Thorpe <>
List: source-changes
Date: 10/27/2005 21:01:19
On Oct 27, 2005, at 5:01 PM, Christos Zoulas wrote:

> - add gem_stop() in attach

Why?  We reset the chip anyway, right?  Several FreeBSD drivers call  
the stop routine in attach, and as far as I am concerned, it is  
simply never necessary (or even appropriate) to do so.

> - add handler in ioctl for add/del multi

That is not necessary -- we call ether_ioctl(), which handles it all  
for us.  We even already have the ENETRESET test to handle multicast  
list updates!  What makes you think this didn't already work?  Please  
note that multicast handling in FreeBSD drivers is very different  
than in NetBSD drivers.

-- thorpej