On Oct 21, 2005, at 12:56 PM, Ross Harvey wrote:

>> From: Manuel Bouyer <bouyer@netbsd.org>
>> Date: Fri, 10 Jun 2005 11:11:38 +0000 (UTC)
>>
>>
>> Module Name:	src
>> Committed By:	bouyer
>> Date:		Fri Jun 10 11:11:38 UTC 2005
>>
>> Modified Files:
>> 	src/sys/net: if_ethersubr.c
>>
>> Log Message:
>> As ether_input() is always called at IPL_NET, there is no need to
>> protect the IF_* operations with splnet()/splx().
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -r1.125 -r1.126 src/sys/net/if_ethersubr.c
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
>
> There are over 100 different ether_input() call sites.

ether_input() is SUPPOSED to be called at splnet().

>
> Are you sure that none of them are ever made at splsoftnet()?
> (Perhaps from a callout?) I too wondered if the splnet()
> was redundant; perhaps the idea was to require only splsoftnet().
>
> //

-- thorpej