Subject: Re: CVS commit: src/sys/dev/ic
To: David Young <firstname.lastname@example.org>
From: Sam Leffler <email@example.com>
Date: 10/13/2005 19:08:03
David Young wrote:
> On Fri, Oct 14, 2005 at 12:26:45AM +0000, Greg Troxel wrote:
>>Module Name: src
>>Committed By: gdt
>>Date: Fri Oct 14 00:26:45 UTC 2005
>> src/sys/dev/ic: ath.c
>>When bringing an interface up, and thus perhaps having just powered it
>>on (e.g. cardbus), write the wep keys to the card. Fixes problem of
>>receiving gibberish if one has set wep keys before bringing the
>>interface up, and also after ifconfig ath0 down; ifconfig ath0 up.
>>(Tested with current from 20050926 with local mods, and discussed with
>>sam@ and dyoung@. This is not 100% right, but significantly better
>>than before. Really we should have an interator in net80211 to repush
>>all key state, include per-node keys.)
> ISTR Sam explained that is not necessary, since there can be no per-node
> keys to restore on the INIT->* transition.
Correct. I believe the only issue is restoring keys in the global key
table on resume because the cardbus socket was powered off. Other key
cache entries will have been invalidated because the state machine is
clocked to INIT (e.g. dropping any associated stations in ap mode).
Note that the key cache contents are preserved across low power
operating modes (of the ath parts) so the only case is when restoring
state after socket power-on or equivalent.