Subject: Re: CVS commit: src/sys/dev/ic
To: Rui Paulo <rpaulo@NetBSD.org>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: source-changes
Date: 08/10/2005 15:16:04
On Wed, Aug 10, 2005 at 02:11:16PM +0100, Rui Paulo wrote:
> On 2005.08.10 11:16:54 +0000, Manuel Bouyer wrote:
> | 
> | Module Name:	src
> | Committed By:	bouyer
> | Date:		Wed Aug 10 11:16:53 UTC 2005
> | 
> | Modified Files:
> | 	src/sys/dev/ic: wdc.c
> | 
> | Log Message:
> | Also initialize wdc->reset in wdcprobe() if the bus back-end didn't provide
> | one. Prevent NULL pointer dereference when wdcprobe() is called.
> 
> I think there is a line missing:
> 
> Index: sys/dev/ic/wdc.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/ic/wdc.c,v
> retrieving revision 1.227
> diff -u -p -r1.227 wdc.c
> --- sys/dev/ic/wdc.c    10 Aug 2005 11:16:53 -0000      1.227
> +++ sys/dev/ic/wdc.c    10 Aug 2005 13:11:57 -0000
> @@ -397,6 +397,8 @@ wdc_drvprobe(struct ata_channel *chp)
>  int
>  wdcprobe(struct ata_channel *chp)
>  {
> +       struct wdc_softc *wdc = CHAN_TO_WDC(chp);
> +

Ha yes, sorry. Fixed.

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--