Subject: Re: CVS commit: src/usr.sbin/pkg_install/add
To: Dan McMahill <dmcmahill@NetBSD.org>
From: James Chacon <jmc@NetBSD.org>
List: source-changes
Date: 04/07/2005 11:39:35
On Tue, Apr 05, 2005 at 04:37:50PM +0000, Dan McMahill wrote:
> 
> Module Name:	src
> Committed By:	dmcmahill
> Date:		Tue Apr  5 16:37:50 UTC 2005
> 
> Modified Files:
> 	src/usr.sbin/pkg_install/add: perform.c
> 
> Log Message:
> Fix a minor bug in the estimation of required disk space.  In particular
> make sure we use a data type which is big enough.  This fixes a problem
> where pkg_add-ing of a binary package which is between 512 Mb and 1 Gb
> failes because the estimated required disk space is negative due to over
> flowing in the calculation

This breaks on all 64bit builds: (alpha for instance)

--- perform.o ---
/home/builds/ab/HEAD/src/usr.sbin/pkg_install/add/perform.c: In function `pkg_do':
/home/builds/ab/HEAD/src/usr.sbin/pkg_install/add/perform.c:311: warning: long long int format, __uint64_t arg (arg 2)
*** [perform.o] Error code 1

James