Subject: Re: CVS commit: src/sys/dev
To: YAMAMOTO Takashi <email@example.com>
From: Manuel Bouyer <firstname.lastname@example.org>
Date: 03/31/2005 15:45:19
On Thu, Mar 31, 2005 at 08:33:17PM +0900, YAMAMOTO Takashi wrote:
> > Module Name: src
> > Committed By: bouyer
> > Date: Wed Mar 30 19:23:08 UTC 2005
> > Modified Files:
> > src/sys/dev: vnd.c vndvar.h
> > Log Message:
> > Make vnd do I/O to the underlying file from thread context. This
> > allows the strategy routine to be called from interrupt context, fixes
> > PR kern/29775 by Juan RP.
> > Now that pool_get() is only called from thread context, change PR_NOWAIT to
> > PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
> > OK'd by thorpej@
> doesn't "goto kthread_end" leak vnx and bp?
Yes. I think at this point we should just wait for the buffer to complete I/O
(that it, remove the VNF_VUNCONF check at this place, and let it
complete the for (resid = bp->b_resid; resid; resid -= sz) loop).
Does this sounds good ?
There also was an issue with the buffers in the queue, but I see you already
Manuel Bouyer <email@example.com>
NetBSD: 26 ans d'experience feront toujours la difference