Subject: Re: CVS commit: src/sys/ufs
To: None <mycroft@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 12/20/2004 10:55:47
> Module Name:	src
> Committed By:	mycroft
> Date:		Wed Dec 15 07:11:51 UTC 2004
> 
> Modified Files:
> 	src/sys/ufs/ext2fs: ext2fs_bmap.c
> 	src/sys/ufs/ffs: ffs_alloc.c ffs_balloc.c ffs_softdep.c
> 	src/sys/ufs/ufs: ufs_bmap.c
> 
> Log Message:
> Remove some unnecessary (int32_t) casts that would cause us to screw up the
> top bit in block addresses.
> 
> Also, change some daddr_t->int32_t casts (mostly as arguments to ufs_rw32(),
> where they would get promoted anyway) to u_int32_t.

i don't think these changes are correct.
at least lfs depends on signed daddr_t.

YAMAMOTO Takashi