Subject: CVS commit: src/sys/dev/scsipi
To: None <>
From: Charles M. Hannum <>
List: source-changes
Date: 09/18/2004 18:49:51
Module Name:	src
Committed By:	mycroft
Date:		Sat Sep 18 18:49:51 UTC 2004

Modified Files:
	src/sys/dev/scsipi: scsipi_base.c

Log Message:
If our enqueue failed -- because we're polling and there is already something
in the queue -- do not attempt to requeue it.  We only poll in two cases:

1) We have a non-interrupting controller.  In this case, execution of the
   previous command should have left the queue empty.  (Perhaps there should be
   a KASSERT() to this effect.)

2) We're in the shutdown path, either doing a cache sync or a dump.  In these
   cases, the retry behavior is useless, because we will no longer get
   interrupts to notify us that the earlier commands completed.  Instead we
   just spin for a few seconds and fail anyway.  (XXX We should probably clear
   the queue explicitly so that the shutdown/dump will succeed.)

To generate a diff of this commit:
cvs rdiff -r1.119 -r1.120 src/sys/dev/scsipi/scsipi_base.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.