Subject: sbappendaddrchain
To: None <jonathan@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 05/29/2004 20:26:33
> Module Name:	src
> Committed By:	jonathan
> Date:		Thu May 27 19:19:00 UTC 2004
> 
> Modified Files:
> 	src/sys/kern: uipc_socket2.c
> 	src/sys/netipsec: key.c
> 	src/sys/sys: socketvar.h
> 
> Log Message:
> Rework to make  FAST_IPSEC PF_KEY dumps unicast and reliable:
> 
> Introduce new socket-layer function sbappendaddrchain() to
> sys/kern/uipc_socket2.c: like sbappendaddr(), only takes a chain of
> records and appends the entire chain in one pass. sbappendaddrchain()
> also takes an `sbprio' argument, which indicates the caller requires
> special `reliable' handling of the socket-buffer.  `sbprio' is
> described in sys/sys/socketvar.h, although (for now) the different
> levels are not yet implemented.

- m_prepend_sockaddr is not compilable with MBUFTRACE.
- sbappendaddrchain seems to leak mbufs and socket buffer space on error.
- sbappendaddrchain should do m_claim on records in m0.
- please use SBLASTRECORDCHK etc.

YAMAMOTO Takashi