Subject: Re: CVS commit: src/usr.bin/gzip
To: None <mrg@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 03/30/2004 18:22:53
hi,

> Module Name:	src
> Committed By:	mrg
> Date:		Tue Mar 30 09:15:07 UTC 2004
> 
> Modified Files:
> 	src/usr.bin/gzip: gzip.c unbzip2.c
> 
> Log Message:
> patch from tron@ to convert to using public bz interfaces.  simonb says
> no reason not to and this fixes PR#24964.

doesn't this make auto format detection for stdin harder?
i'd suggest the following instead.

YAMAMOTO Takashi


Index: unbzip2.c
===================================================================
RCS file: /lfs/c/NetBSD/src/usr.bin/gzip/unbzip2.c,v
retrieving revision 1.1
diff -u -p -r1.1 unbzip2.c
--- unbzip2.c	1 Jan 2004 02:44:09 -0000	1.1
+++ unbzip2.c	30 Mar 2004 01:38:55 -0000
@@ -56,8 +56,7 @@ unbzip2(int in, int out)
 	                                maybe_err(1, "write");
 	                }
 	                bytes_out += n;
-	                if (ret == BZ_STREAM_END)
-	                        break;
+			break;
 
 	        case BZ_DATA_ERROR:
 	                maybe_errx(1, "bzip2 data integrity error");